-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
artifactory - Fix for ClusterIP type service with external ingress offloading #1906
artifactory - Fix for ClusterIP type service with external ingress offloading #1906
Conversation
…ClusterIP service type and https / tls offloading on external ingress
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
Hi @fwdIT, Thank you for raising PR, we will take this internally and fix this in upcoming releases. We will update you |
Any update on this? For us it won't be optimal to start with manually tweaked upstream helm charts for our automated installation. During the POC, this was no issue. We however now, since we are licensed, need to automate the install and we don't want to use custom adjusted vendor helm charts for this. We should only need to adjust the values, not the logic. |
@fwdIT Reminder to review |
@RobinDuhan sorry for the delay, looks fine by me thx for the tweaks and additions! this will help us not needing to use manually adjusted helm charts like today looking forward to the release |
@fwdIT Great, thank you for verifying this at your end as well. |
@RobinDuhan when will this #1926 be merged and present in the main repo? |
@fwdIT This is taken with the ongoing release. This will tentatively be available by mid-end next week. |
Fixes current helm chart limitations for external ingress with nginx ClusterIP service type and https / tls offloading on external ingress
In our case basic OpenShift 4.12.x install where the ingress is not the standard nginx which comes with the helm install
PR Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[artifactory]
)What this PR does / why we need it:
Support for OpenShift type installations
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #fixes # 308262 (support case @ JFrog)
Special notes for your reviewer:
discussed with [email protected]