Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Aborted label #104

Merged
merged 14 commits into from
Oct 31, 2024
Merged

Add Aborted label #104

merged 14 commits into from
Oct 31, 2024

Conversation

fudler
Copy link
Collaborator

@fudler fudler commented Jun 25, 2024

Depending on this issue: TNG/JGiven#1625
See the last comments in the thread.

@fudler fudler requested a review from RobertSchueler June 25, 2024 06:56
Copy link
Collaborator

@RobertSchueler RobertSchueler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not find any other places where the step status is relevant. But don't we need to handle the scenario status "ABORTED" as well? What I found that may be relevant are lines 370, 454, 492, but maybe even more.

Signed-off-by: Christian Oertel <christian.oertel@tngtech.com>
Signed-off-by: Christian Oertel <christian.oertel@tngtech.com>
@l-1squared l-1squared force-pushed the feature/include_aborted branch from 10ddfd8 to 164d8bb Compare September 27, 2024 05:24
Signed-off-by: l-1squared <30831153+l-1squared@users.noreply.github.com>
Signed-off-by: l-1squared <30831153+l-1squared@users.noreply.github.com>
Signed-off-by: l-1squared <30831153+l-1squared@users.noreply.github.com>
Signed-off-by: l-1squared <30831153+l-1squared@users.noreply.github.com>
…js in the index.html

There is one added by webpack at the end but I think that we probably want the app loading at the beginning b/c of the adaption we are making with loading in the script.

Signed-off-by: l-1squared <30831153+l-1squared@users.noreply.github.com>
@l-1squared l-1squared force-pushed the feature/include_aborted branch from 0820635 to 181efa2 Compare October 25, 2024 05:37
@l-1squared l-1squared marked this pull request as ready for review October 25, 2024 06:59
Signed-off-by: l-1squared <30831153+l-1squared@users.noreply.github.com>
Signed-off-by: l-1squared <30831153+l-1squared@users.noreply.github.com>
@l-1squared l-1squared force-pushed the feature/include_aborted branch from 3f1824f to b8cbab1 Compare October 25, 2024 07:35
Signed-off-by: l-1squared <30831153+l-1squared@users.noreply.github.com>
Signed-off-by: l-1squared <30831153+l-1squared@users.noreply.github.com>
Signed-off-by: l-1squared <30831153+l-1squared@users.noreply.github.com>
@l-1squared l-1squared force-pushed the feature/include_aborted branch from ae942ed to bfc7aea Compare October 25, 2024 08:05
legacy/vite.config.ts Outdated Show resolved Hide resolved
$scope.labels = ['Successful', 'Failed', 'Pending'];
$scope.colors = [green, red, gray];
$scope.labels = ['Successful', 'Failed', 'Pending', 'Aborted'];
$scope.colors = [green, red, silver, gray];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we are changing the 'Pending' state from gray to silver - is it on purpose?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup

@l-1squared l-1squared merged commit 3cfab7d into master Oct 31, 2024
7 checks passed
@l-1squared l-1squared deleted the feature/include_aborted branch October 31, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants