-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Aborted label #104
Add Aborted label #104
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not find any other places where the step status is relevant. But don't we need to handle the scenario status "ABORTED" as well? What I found that may be relevant are lines 370, 454, 492, but maybe even more.
Signed-off-by: Christian Oertel <christian.oertel@tngtech.com>
Signed-off-by: Christian Oertel <christian.oertel@tngtech.com>
10ddfd8
to
164d8bb
Compare
Signed-off-by: l-1squared <30831153+l-1squared@users.noreply.github.com>
Signed-off-by: l-1squared <30831153+l-1squared@users.noreply.github.com>
Signed-off-by: l-1squared <30831153+l-1squared@users.noreply.github.com>
Signed-off-by: l-1squared <30831153+l-1squared@users.noreply.github.com>
…js in the index.html There is one added by webpack at the end but I think that we probably want the app loading at the beginning b/c of the adaption we are making with loading in the script. Signed-off-by: l-1squared <30831153+l-1squared@users.noreply.github.com>
0820635
to
181efa2
Compare
Signed-off-by: l-1squared <30831153+l-1squared@users.noreply.github.com>
4080e9a
to
2bdb819
Compare
2bdb819
to
3f1824f
Compare
Signed-off-by: l-1squared <30831153+l-1squared@users.noreply.github.com>
3f1824f
to
b8cbab1
Compare
Signed-off-by: l-1squared <30831153+l-1squared@users.noreply.github.com>
Signed-off-by: l-1squared <30831153+l-1squared@users.noreply.github.com>
Signed-off-by: l-1squared <30831153+l-1squared@users.noreply.github.com>
ae942ed
to
bfc7aea
Compare
$scope.labels = ['Successful', 'Failed', 'Pending']; | ||
$scope.colors = [green, red, gray]; | ||
$scope.labels = ['Successful', 'Failed', 'Pending', 'Aborted']; | ||
$scope.colors = [green, red, silver, gray]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we are changing the 'Pending' state from gray to silver - is it on purpose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup
Depending on this issue: TNG/JGiven#1625
See the last comments in the thread.