Refactor scenario overview #88
Conversation
Signed-off-by: Christian Oertel <[email protected]>
Signed-off-by: Christian Oertel <[email protected]>
Signed-off-by: Christian Oertel <[email protected]>
Signed-off-by: Christian Oertel <[email protected]>
Signed-off-by: Christian Oertel <[email protected]>
Signed-off-by: Christian Oertel <[email protected]>
Signed-off-by: Christian Oertel <[email protected]>
|
stuff is weirdly red here |
new/src/index.tsx
Outdated
|
|
||
| const root = ReactDOM.createRoot(document.getElementById("root") as HTMLElement); | ||
|
|
||
| i18n.use(initReactI18next).init({ |
There was a problem hiding this comment.
why did you dump the i18n?
There was a problem hiding this comment.
See above haha. Let's just add it again.
|
still quite red :( |
| </ListItem> | ||
| <ListItem sx={{ paddingTop: 0.1, paddingBottom: 0.1 }}> | ||
| <ListItemText primary={ | ||
| <Link href="http://localhost:3000" underline="none" sx={{ color: 'inherit' }}> |
There was a problem hiding this comment.
We clearly need to start adding routing...
There was a problem hiding this comment.
not part of this PR obv.
| </div> | ||
| </Grid> | ||
| <Grid item xs={12} md={11}> | ||
| <Grid container direction="column"> |
There was a problem hiding this comment.
do you think it would be too bad, if we place the subgrid in a different component?
There was a problem hiding this comment.
I'll keep Todos in the code as a starting point for the... well, workshop!
| <List> | ||
| <ListItem sx={{ paddingTop: 0.1, paddingBottom: 0.1 }}> | ||
| <ListItemText primary={ | ||
| <Link href="http://localhost:3000" underline="none" sx={{ color: 'inherit' }}> |
There was a problem hiding this comment.
we really should not use the base url here. I just ended up on the playwright react app.
just using the path might work
There was a problem hiding this comment.
For now, I'd just keep it and provide a comment for future use.
| /> | ||
| </ListItem> | ||
| </List> | ||
| <ListItem> |
There was a problem hiding this comment.
again, "forEach" could be put to good use here
There was a problem hiding this comment.
First, let's keep it like this. The fix here might be a good introduction for someone in the workshop.
fudler
force-pushed
the
refactor_scenario_overview
branch
3 times, most recently
from
884ee67 to
c1e68f5
Compare
Signed-off-by: Christian Oertel <[email protected]>
fudler
force-pushed
the
refactor_scenario_overview
branch
from
c1e68f5 to
8786f5e
Compare
|
So, the red stuff is gone. I left some of your comments "unresolved" in the sense of "we use them as basis for the workshop". |
Let us create some common ground!