Clean code: remove unused constant (#28384)

jhipster · Jan 5, 2025 · 8566b30 · 8566b30
1 parent 7ebb915
commit 8566b30
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 53 deletions.
diff --git a/...ates/src/main/webapp/app/entities/_entityFolder_/service/_entityFile_.service.spec.ts.ejs b/...ates/src/main/webapp/app/entities/_entityFolder_/service/_entityFile_.service.spec.ts.ejs
@@ -18,7 +18,6 @@
 -%>
 <%_
 const tsKeyId = primaryKey.tsSampleValues[0];
-const enumImports = generateEntityClientEnumImports(fields);
 _%>
 import { TestBed } from '@angular/core/testing';
 import { provideHttpClientTesting, HttpTestingController } from '@angular/common/http/testing';

diff --git a/...lates/src/main/webapp/app/entities/_entityFolder_/update/_entityFile_-form.service.ts.ejs b/...lates/src/main/webapp/app/entities/_entityFolder_/update/_entityFile_-form.service.ts.ejs
@@ -66,15 +66,15 @@ type <%= entityAngularName %>FormDefaults = Pick<New<%= entityAngularName %>, '<
 
 type <%= entityAngularName %>FormGroupContent = {
 <%_ for (field of fields) {
-      const { fieldName, fieldType, fieldTypeBlobContent, fieldValidationRequired, tsType, fieldIsEnum } = field;
+      const { fieldName } = field;
 _%>
   <%= fieldName %>: FormControl<<%= entityFormName %>['<%= fieldName %>']<% if (field.id) { %> | New<%= entityAngularName %>['<%= fieldName %>']<% } %>>;
   <%_ if (field.fieldTypeBinary && !field.blobContentTypeText) { _%>
   <%= fieldName %>ContentType: FormControl<<%= entityFormName %>['<%= fieldName %>ContentType']>;
   <%_ } _%>
 <%_ } _%>
 <%_ for (const relationship of relationships.filter(relationship => relationship.persistableRelationship)) {
-      const { propertyName, otherEntity } = relationship;
+      const { propertyName } = relationship;
 _%>
   <%= propertyName %>: FormControl<<%= entityFormName %>['<%= propertyName %>']>;
 <%_ } _%>
@@ -104,7 +104,7 @@ export class <%= entityAngularName %>FormService {
 
     return new FormGroup<<%= entityAngularName %>FormGroupContent>({
 <%_ for (const field of fields) {
-      const { fieldName, fieldType, fieldTypeBlobContent, fieldValidateRules, fieldTypeTemporal, fieldValidationRequired, fieldValidationMinLength, fieldValidationMaxLength, fieldValidationMin, fieldValidationMax, fieldValidationPattern } = field;
+      const { fieldName, fieldValidationRequired, fieldValidationMinLength, fieldValidationMaxLength, fieldValidationMin, fieldValidationMax, fieldValidationPattern } = field;
       const usesValidators = fieldValidationRequired || fieldValidationMinLength || fieldValidationMaxLength || fieldValidationMin || fieldValidationMax || fieldValidationPattern || field.id;
 _%>
       <%= fieldName %>: new FormControl(
@@ -146,7 +146,7 @@ _%>
   <%_ } _%>
 <%_ } _%>
 <%_ for (const relationship of relationships.filter(relationship => relationship.persistableRelationship)) {
-      const { relationshipRequired, propertyName, relationshipName, collection, otherEntity } = relationship;
+      const { relationshipRequired, propertyName, collection } = relationship;
 _%>
       <%= propertyName %>: new FormControl(
         <%= entityInstance %>RawValue.<%= propertyName %><% if (collection) { %> ?? []<% } %>
@@ -198,7 +198,7 @@ _%>
 
     return {
   <%_ for (field of fields) {
-        const { fieldName, fieldTypeBoolean, fieldTypeTimed, fieldTypeLocalDate } = field;
+        const { fieldName, fieldTypeBoolean, fieldTypeTimed } = field;
   _%>
     <%_ if (field.fieldTsDefaultValue) { _%>
         <%= fieldName %>: <%- field.fieldTsDefaultValue %>,
@@ -213,7 +213,7 @@ _%>
     <%_ } _%>
   <%_ } _%>
   <%_ for (const relationship of relationships.filter(({ persistableRelationship }) => persistableRelationship)) {
-        const { relationshipRequired, propertyName, collection, otherEntity, relationshipName } = relationship;
+        const { propertyName, collection } = relationship;
   _%>
     <%_ if (collection) { _%>
       <%= propertyName %>: [],
@@ -248,7 +248,7 @@ _%>
   <%_ } _%>
 <%_ } _%>
 <%_ for (const relationship of relationships.filter(({ persistableRelationship }) => persistableRelationship)) {
-      const { relationshipRequired, propertyName, collection } = relationship;
+      const { propertyName, collection } = relationship;
 _%>
   <%_ if (collection) { _%>
       <%= propertyName %>: <%= entityInstance %>.<%= propertyName %> ?? [],

diff --git a/generators/bootstrap-application-base/utils.ts b/generators/bootstrap-application-base/utils.ts
@@ -31,45 +31,6 @@ const { CommonDBTypes } = fieldTypes;
 
 const { STRING: TYPE_STRING, BOOLEAN: TYPE_BOOLEAN, INSTANT } = CommonDBTypes;
 
-export const auditableEntityFields = () => [
-  {
-    fieldName: 'createdBy',
-    fieldType: TYPE_STRING,
-    readonly: true,
-    skipServer: true,
-    builtIn: true,
-    fieldValidateRules: [Validations.MAXLENGTH],
-    fieldValidateRulesMaxlength: 50,
-    autoGenerate: true,
-  },
-  {
-    fieldName: 'createdDate',
-    fieldType: INSTANT,
-    readonly: true,
-    skipServer: true,
-    builtIn: true,
-    autoGenerate: true,
-  },
-  {
-    fieldName: 'lastModifiedBy',
-    fieldType: TYPE_STRING,
-    readonly: true,
-    skipServer: true,
-    builtIn: true,
-    fieldValidateRules: [Validations.MAXLENGTH],
-    fieldValidateRulesMaxlength: 50,
-    autoGenerate: true,
-  },
-  {
-    fieldName: 'lastModifiedDate',
-    fieldType: INSTANT,
-    readonly: true,
-    skipServer: true,
-    builtIn: true,
-    autoGenerate: true,
-  },
-];
-
 const authorityEntityName = 'Authority';
 
 export function createUserEntity(this: BaseApplicationGenerator, customUserData = {}, application): Partial<UserEntity> {

diff --git a/...plates/src/main/java/_package_/_entityPackage_/service/_entityClass_QueryService.java.ejs b/...plates/src/main/java/_package_/_entityPackage_/service/_entityClass_QueryService.java.ejs
@@ -21,10 +21,7 @@ package <%= entityAbsolutePackage %>.service;
 <%_
 const serviceClassName = entityClass + 'QueryService';
 const instanceType = restClass;
-const instanceName = restInstance;
 const mapper = entityInstance  + 'Mapper';
-const dtoToEntity = mapper + '.'+ 'toEntity';
-const entityToDto = mapper + '.'+ 'toDto';
 const entityListToDto = mapper + '.' + 'toDto';
 const entityToDtoReference = mapper + '::'+ 'toDto';
 const repository = entityInstance  + 'Repository';

diff --git a/...es/src/main/java/_package_/_entityPackage_/service/impl/_entityClass_ServiceImpl.java.ejs b/...es/src/main/java/_package_/_entityPackage_/service/impl/_entityClass_ServiceImpl.java.ejs
@@ -26,11 +26,8 @@ const optionalOrMono = (reactive) ? 'Mono' : 'Optional';
 const listOrFlux = (reactive) ? 'Flux' : 'List';
 const pageOrFlux = (reactive) ? 'Flux' : 'Page';
 const mapper = entityInstance  + 'Mapper';
-const dtoToEntity = mapper + '.'+ 'toEntity';
-const entityToDto = 'toDto';
 const entityToDtoReference = mapper + '::'+ 'toDto';
 const repository = entityInstance  + 'Repository';
-const searchRepository = entityInstance  + 'SearchRepository';
 
 _%>
 <%_ if (serviceImpl) { _%>