Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guarantee a C-string termination #65

Merged
merged 1 commit into from
Jun 17, 2018
Merged

Guarantee a C-string termination #65

merged 1 commit into from
Jun 17, 2018

Conversation

zhkvia
Copy link

@zhkvia zhkvia commented Nov 13, 2017

No description provided.

@zhkvia zhkvia mentioned this pull request Nov 13, 2017
@braian87b
Copy link
Collaborator

Have you tested this ?
any comments on this ?

@braian87b braian87b merged commit 5859511 into jiangwen365:master Jun 17, 2018
@zhkvia
Copy link
Author

zhkvia commented Jun 17, 2018

Thanks for the response. This PR is connected to this issue.

It worked for me back then but still seems like a hack. I was trying to understand why a buffer becomes dirty looking at how pyodbc processes strings, but at some point switched from working with ODBC to other projects.

@braian87b
Copy link
Collaborator

Ok, we will take a look at this, we are planning some work to do in order to improve the overall experience with pypyodbc, #79

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants