New title #140
Merged
New title #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 9bd4835): https://dailyfield-a845d--pr140-newtitle-hn5jzt4g.web.app (expires Sat, 27 Mar 2021 08:58:38 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
atn832
reviewed
Mar 16, 2021
atn832
reviewed
Mar 16, 2021
atn832
reviewed
Mar 16, 2021
atn832
reviewed
Mar 16, 2021
atn832
reviewed
Mar 16, 2021
atn832
reviewed
Mar 16, 2021
jiji14
commented
Mar 20, 2021
| <div className="info highlight">{match.place}</div> | ||
| {match.isRecurringClass && ( | ||
| <div className="info highlight">{match.place}</div> | ||
| )} |
There was a problem hiding this comment.
기획반일때만 장소 보이도록 요청해서 수정했어~ (왜냐면 일반 매치는 제목 = 장소일거라서 한번만 보여주면 될거야!)
There was a problem hiding this comment.
이상해. 그럼 경기도 제목 말고 match.place에 보이는게 어때? 똑같은 정보 인데 다른 곳에 보이면 좀 헷갈려. 코치님이랑 다시 확인 할수 있어? 강하게 반대 하면 코치님이 원하는대로 괜찮아.
There was a problem hiding this comment.
그리고 UI만 아니라 코드 지저분 해져. 나중에 다른 개발자가 이거 읽으면 왜 UI다르는지 이해 못 할거야.
atn832
approved these changes
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
매치 제목하고 구장 분리했어!
왜냐면 제목에 구장말고 다른 강조하고 싶은 정보 넣을때 많아 (ex) *초급위주 *1자리남음!