Update year length to the actual Gregorian length #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Gregorian Calendar, the one we generally use for day to day, has an average year length of 365.2425 days. This is because the three rules for counting leap years are: - year % 4 == 0: leap - year % 100 == 0: normal - year % 400 == 0: leap Which is why 2000, for example, was a leap year. So it would be a good idea to update this number to be more accurate. On a side note, the value before this commit, 365.24, _is_ accurate for the Julian Calendar, on which the Gregorian is based. It just started getting out of sync with the seasons (Easter was creeping closer to June), so a revision was commissioned, and now here we are!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Gregorian Calendar, the one we generally use for day to day, has an average year length of 365.2425 days. This is because the three rules for counting leap years are:
Which is why 2000, for example, was a leap year. So it would be a good idea to update this number to be more accurate.
On a side note, the value before this commit, 365.24, is accurate for the Julian Calendar, on which the Gregorian is based. It just started getting out of sync with the seasons (Easter was creeping closer to June), so a revision was commissioned, and now here we are!