-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update common.css #67
base: master
Are you sure you want to change the base?
Conversation
A chrome-bookmark-like style. The green style may not match its surroundings enough, so some people may dislike it on the first look. I just modified the css as little as possible. You, as the author, are welcome to modify the details to combine my suggestion and your design theme. If you want it closer to chrome bookmark bar, some fading effects, I think, are required using js. Before you implement the self-defined css function or before you find any other css config good enough, you can perhaps adopt this css. Among all ext's I've searched, yours is the one closest to the chrome original concise new-tab. That's why I try contributing a little to your project. Good luck to your ext!
I see, I forgot to turn on TopSite to test. What I see is that all 's in topsites do not change lines automatically. So "display: block" is required for them. However, "display: block" is redundant for those contained in div.bookmarks-container. So maybe I tend to define another css set for those in TopSite. For example, <a class="textanchor bookmark"> boomark1 </a>.... a.textanchor defines the properties they have in common; It's my web design style, just for your reference. |
I simply put back the "display:block" in a.bookmark. But this property is also defined in div.bookmarks-container .bookmark. I'm not sure why chrome chooses the latter when a conflict occurs. More details can be seen in my previous post.
I think my point is that it's not redundant.
I also didn't check the options page to see if it was also displayed oddly.
|
How about defining "display: block;" in "div.top-sites-wrapper .inner a.bookmark" selector? In my style, i may do that. |
Yeah that may make more sense. The reason I have this bookmark class in the first place is because I plan I probably should have moved all block definitions to the more specific As a web developer, would you find value in it if the specificity was
|
A chrome-bookmark-like style. The green style may not match its surroundings enough, so some people may dislike it on the first look.
I just modified the css as little as possible. You, as the author, are welcome to modify the details to combine my suggestion and your design theme. If you want it closer to chrome bookmark bar, some fading effects, I think, are required using js.
Before you implement the self-defined css function or before you find any other css config good enough, you can perhaps adopt this css.
Among all ext's I've searched, yours is the one closest to the chrome original concise new-tab. That's why I try contributing a little to your project.
Good luck to your ext!