Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FindCImg.cmake #103

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Update FindCImg.cmake #103

merged 3 commits into from
Oct 25, 2023

Conversation

Neumann-A
Copy link
Contributor

a) You probably want to use (builtin) FindThreads.cmake instead some not existing FindPTHREAD.cmake

b) You probably want to use just find_library for GDI instead of some not existing FindGDI.cmake

@jkriege2
Copy link
Owner

Hi!

That are some unfortunate errors that did not come up so far due to problems with the Appveyor-build (it didn't build the CImag examples on Ubuntu) and due to the fact that I'm working solely on windows.

It seems there are two parts to this:

  1. The PTHreads-fix should be fine,
  2. BUT the GDI-fix does not really work ... I think I will rework this to do it the same way, it is done in the examples for CImg: https://github.com/GreycLab/CImg/blob/master/examples/CMakeLists.txt ...

If you like, could you change the PR to match the CMakeLists.txt given above ... or remove the GDI-part and I will do that part myself (and I will merge the PThreads part).

Thanks for the PR anyways,
JAN

@Neumann-A
Copy link
Contributor Author

Let me just quickly remove gdi32 completely since it should be automatically linked in by CMake (via CMAKE_<LANG>_STANDARD_LIBRARIES)

https://gitlab.kitware.com/cmake/cmake/-/blob/master/Modules/Platform/Windows-GNU.cmake?ref_type=heads#L47
https://gitlab.kitware.com/cmake/cmake/-/blob/master/Modules/Platform/Windows-MSVC.cmake?ref_type=heads#L226

@jkriege2
Copy link
Owner

Hi!

I just fixed the appveyor build-scripts in master to actually build with CImg on Ubuntu ... COuld you rebase your PR, which should also rerun the CI? Then we see whether the changes worked!

Best,
JAN

@jkriege2 jkriege2 merged commit e3cfac3 into jkriege2:master Oct 25, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants