Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows rails 7 with minor versions #200

Closed

Conversation

aYaremchuk
Copy link

@aYaremchuk aYaremchuk commented Jan 26, 2024

Rails 7.1.3 incompatible

Could not find compatible versions

Because every version of crypt_keeper depends on activerecord >= 7.0.0, < 7.1.A
  and rails >= 7.1.3 depends on activerecord = 7.1.3,
  every version of crypt_keeper is incompatible with rails >= 7.1.3.
So, because Gemfile depends on rails = 7.1.3
  and Gemfile depends on crypt_keeper >= 0,
  version solving has failed.

Added minor change to support minor versions of rails 7
Also changed path version of gem

@aYaremchuk aYaremchuk force-pushed the allow_minor_versions_rails_7 branch from a4343ee to 43b9ea2 Compare January 26, 2024 14:06
@jmazzi
Copy link
Owner

jmazzi commented Feb 5, 2024

@aYaremchuk the tests are failing

@aYaremchuk aYaremchuk force-pushed the allow_minor_versions_rails_7 branch from 43b9ea2 to a5da687 Compare February 28, 2024 10:12
@Capncavedan Capncavedan mentioned this pull request Mar 19, 2024
@jmazzi
Copy link
Owner

jmazzi commented Mar 19, 2024

@Capncavedan @aYaremchuk tests are still failing as of today; please consider investigating this if you would like to see a gem cut for this version.

@johan-smits
Copy link
Contributor

@jmazzi looking at the changes it would suspect to fail only for the 7.1 rails versions. But all tests fail also the previous ones. Could it be that also the main branch fails recently?

@aYaremchuk
Copy link
Author

There is an issue with public/private keys.
These keys do not have an expiration date, but tests fail even with minor changes.

It appears this issue was resolved in the following pull request: 203.

@aYaremchuk
Copy link
Author

Closing this PR.

It seems the issue with the broken tests was resolved in this pull request: link.

@aYaremchuk aYaremchuk closed this Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants