Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes disable_cool and disable_auto along with localisation #15

Merged
merged 11 commits into from
Dec 6, 2023

Conversation

DavidGeorge528
Copy link
Contributor

@DavidGeorge528 DavidGeorge528 commented Dec 5, 2023

This PR fixes #14 including the following:

  • Renamed disable_eco to disable_auto to allow auto HVAC mode to be hidden
  • Fixes a bug where disable_cool would actually hide auto and vice versa
  • Adds localisation for disable_auto and disable_cool

Optional things to do:

  • Check localisation
  • Add disable_heat_cool and localisation
  • Add disable_dry and localisation
  • Add disable_fan_only and localisation
  • Test disable_heat_cool
  • Test disable_dry
  • Test disable_fan_only

@DavidGeorge528
Copy link
Contributor Author

Changes have been tested. Below screenshot shows localisation for disable_cool which was missing for en and the ability to disable_auto.
image

@DavidGeorge528
Copy link
Contributor Author

Added the ability to disable the 3 missing HVAC modes (heat_cool, dry, fan_only). However these are untested as I have no thermostats with those options. Updated PR with task to test them.

@DavidGeorge528
Copy link
Contributor Author

Using a Custom thermostat I was able to test and verify heat_cool, dry and fan_only.

image

image

Also verified that all possible HVAC modes work

image

@jmcollin78
Copy link
Owner

Hey @DavidGeorge528 n,

Many thanks for this !

@jmcollin78 jmcollin78 merged commit e18c5e9 into jmcollin78:master Dec 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Disable Auto Button (And other HVAC mode buttons)
2 participants