Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create sk.json #135

Merged
merged 3 commits into from
Oct 29, 2023
Merged

Create sk.json #135

merged 3 commits into from
Oct 29, 2023

Conversation

misa1515
Copy link
Contributor

No description provided.

@jmcollin78
Copy link
Owner

Thank you @misa1515 for your contribution. I will publish a new release with new key to translate. So I keep the PR open until I publish the new keys.

@jmcollin78
Copy link
Owner

Hello @misa1515? I have pusblish some new strings for translations. Can you please rebase with the main branch and add the missing keys ?

Thank you in advance

Copy link
Contributor Author

@misa1515 misa1515 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@jmcollin78
Copy link
Owner

jmcollin78 commented Oct 28, 2023

Sorry but there is more keys missing. I add all thoses keys in the strings.json:

         "valve_entity_id": "1rst valve number",
          "valve_entity2_id": "2nd valve number",
          "valve_entity3_id": "3rd valve number",
          "valve_entity4_id": "4th valve number",
          "auto_regulation_mode": "Self-regulation mode"

You should find it 4 times: in type/data, type/data_description and same in options section.

@misa1515
Copy link
Contributor Author

no problem.
Last time was only 1 more code line (when I checked it).
Now are more new lines.
Updated.

@jmcollin78
Copy link
Owner

I will merge. But because I'm still developping some features, may I ask you some translations ? I will integrate them.

"auto_regulation_strong": "Strong",
"auto_regulation_medium": "Medium",
"auto_regulation_light": "Light",
"auto_regulation_none": "No auto-regulation"
"auto_regulation_mode": "Self-regulation"
"auto_regulation_mode": "Auto adjustment of the target temperature"

Thank you in advance !

@jmcollin78 jmcollin78 merged commit 88760db into jmcollin78:main Oct 29, 2023
3 of 4 checks passed
@jmcollin78 jmcollin78 added the developed When development is done and tested label Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developed When development is done and tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants