-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add attribute with active underlyings for easier tracking and setup #658
Open
s256
wants to merge
6
commits into
jmcollin78:main
Choose a base branch
from
s256:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
3734fa0
Add attribute with active underlyings for easier tracking and setup
77579d9
Issue #645 add sonoff trvzb (#651)
jmcollin78 b8791c4
Documentation rework
02e8450
En links
6efec66
Documentation issue #650
6617da0
Merge branch 'main' into main
s256 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the
active_device_names
into the list of_entity_component_unrecorded_attributes
so that it will not be persisted and save place on the hard drive.See base_thermostat.py at line 32 to have an exemple.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your feedback! Happy to adapt it :)
But I am not sure if I can follow. L32 doesnt look right as an example.
Generally yes: we don't want to persist this on the hard drive.
My code extends the general configuration.
So I was now looking to the list of
_entity_component_unrecorded_attributes
which is assigned to the central configuration.But all
_entity_component_unrecorded_attributes
I could find are assigned to either the base thermostat (which hands down basic attributes and entities to all other climate entities) or the actual thermostats.(I am not a dev, so chances are pretty high, I don't understand the code ;) ) sorry :/