fix: no need to ignore testing anymore

jnovack · Apr 2, 2021 · 94cdd4b · 94cdd4b
1 parent 802519a
commit 94cdd4b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 7 deletions.
diff --git a/extras_test.go b/extras_test.go
@@ -197,7 +197,7 @@ func TestFlagSetParseErrors(t *testing.T) {
 
 func TestTestingPackageFlags(t *testing.T) {
 	f := NewFlagSet("test", ContinueOnError)
-	if err := f.Parse([]string{"-test.v", "-test.count", "1"}); err != nil {
+	if err := f.Parse([]string{"-test.v", "-test.count", "1"}); err == nil {
 		t.Error(err)
 	}
 }
diff --git a/flag.go b/flag.go
@@ -912,7 +912,7 @@ func (f *FlagSet) failf(format string, a ...interface{}) error {
 // or the appropriate default usage function otherwise.
 func (f *FlagSet) usage() {
 	if f.Usage == nil {
-			f.defaultUsage()
+		f.defaultUsage()
 	} else {
 		f.Usage()
 	}
@@ -940,11 +940,6 @@ func (f *FlagSet) parseOne() (bool, error) {
 		return false, f.failf("bad flag syntax: %s", s)
 	}
 
-	// ignore go test flags
-	if strings.HasPrefix(name, "test.") {
-		return false, nil
-	}
-
 	// it's a flag. does it have an argument?
 	f.args = f.args[1:]
 	hasValue := false