Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Move to instancemethods #3

Merged
merged 5 commits into from
Aug 11, 2016
Merged

Move to instancemethods #3

merged 5 commits into from
Aug 11, 2016

Conversation

jnylen
Copy link
Owner

@jnylen jnylen commented Aug 11, 2016

This should be better.
@janko-m could you check and comment?

Closes #2

@jnylen jnylen self-assigned this Aug 11, 2016
@janko
Copy link

janko commented Aug 11, 2016

Awesome, I think this is a big improvement!

I think it's better in the README to show just regular metadata extraction, so that it's not specific to whether people are generating versions or how they name them (although you can include an example on how to extract only for a specific version as well):

add_metadata :dominant_color do |io, context|
  dominant_color(io.path)
end
photo.image.metadata["dominant_color"]
# or
photo.image.dominant_color

Other than that, everything looks great!

@jnylen jnylen merged commit bcb3c7b into master Aug 11, 2016
@jnylen
Copy link
Owner Author

jnylen commented Aug 11, 2016

Thanks @janko-m

@jnylen jnylen deleted the move-to-instancemethods branch August 11, 2016 07:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants