Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snippet parser for new engine #441

Open
wants to merge 3 commits into
base: snippet-engine
Choose a base branch
from

Conversation

immerrr
Copy link
Contributor

@immerrr immerrr commented Dec 6, 2013

This is an alpha version of parser discussed in #381.

It does pass some basic tests, but is by no means finished:

  • it misses proper primary field determination
  • it doesn't try combining field default values and transformations
  • empty fields/mirrors result in (&field NAME nil) rather than (&field NAME)
  • field names are left as strings
  • almost no validation is done
  • it may benefit better error position reporting

I'm afraid I won't have much time to hack on it in nearest future, so I figured I'd clean it up a bit and put it out as is.

@joaotavora
Copy link
Owner

I still haven't had a look at this, sorry, I will try by the end of the month when I resume work on the snippet-engine branch, which isn't making it into the next emacs pretest anyway...

@joaotavora
Copy link
Owner

Looks pretty at first sight, though...

@immerrr
Copy link
Contributor Author

immerrr commented Oct 7, 2014

Hey there, has there been any progress with the rewrite?

@joaotavora
Copy link
Owner

Nope, sorry. I have a lot on my plate right now, but it has not been abandoned. The rewrite will hopefully be in the upcoming emacs version's core (not the 24.4, but the 24.5). @immerrr, if you are interested in tackling it yourself, I can put you up do date with information on the proposed changes by the Emacs maintainers with whom I was coordinating, send me a mail off-list.

@immerrr
Copy link
Contributor Author

immerrr commented Oct 7, 2014

Nope, sorry. I have a lot on my plate right now

Ah, don't worry, all the same here and I'm not going to be of much help either in nearest future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants