Fixes android issue with scaling on android #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And if merging this is taking you to long, I published a package with the fix: https://www.npmjs.com/package/better-react-native-image-viewing |
src/hooks/usePanResponder.ts
Outdated
| @@ -22,6 +22,7 @@ import { | |||
| getDistanceBetweenTouches, | |||
| getImageTranslate, | |||
| getImageDimensionsByTranslate, | |||
| getImageTransform, | |||
There was a problem hiding this comment.
Hey @LimitedDani thanks for this PR, can I ask you what this import for as it's never used below?
There was a problem hiding this comment.
Ummm, i dont know, i will remove it
antonKalinin
reviewed
Jun 8, 2022
| const imageDimensions = getImageDimensionsByTranslate( | ||
| initialTranslate, | ||
| SCREEN | ||
| ); | ||
|
|
||
| useEffect(() => { |
There was a problem hiding this comment.
@LimitedDani Sorry that it takes so long to merge this one, I am unfortunately pretty busy and have very limited time for OS. But I need to ask couple of questions here:
- Why do we need
Animated.parallelhaving single animation in array? - Can you shortly describe the idea, because the approach looks a bit hacky for me. From what I understand we run this effect on every render (no
deps) and we say that zoom is over (onZoom(false)) and we animate zoom back to initial scale.
What was initial problem we are solving? Was it that image stacked after pinch gesture and we were about to return it to initial scale?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.