This repository has been archived by the owner on Oct 10, 2024. It is now read-only.
Handle JavaScript alert() and confirm() by default
#62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helpful when completely custom navigation is required, like presenting a modal from: ``` WKUIDelegate.webView(_:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:) ```
with option to override.
|
Closed in favor of #74. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on the idea from #61, baking in default behavior for JavaScript
alert()andconfirm()dialogs.I'm in favor of having this live in Turbo Navigator / turbo-ios. Especially because a developer can implement the delegate callbacks to customize the behavior entirely.
But it requires the
TurboNavigatorclass to become the UI delegate of the web view. Which means we close off all the other methods inWKUIDelegate. I don't want to expose every single one of these with a default (empty) implementation. But I'm not sure of a more elegant way to handle it.