Successful build of binary for taking a interval value. #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 10, 2015 00:06
Still needs testing on running and memory leaks.
|
What is the loop with the alloc_frame supposed to do? I think this is wrong, it just allocates a data structure, it does not decode (and therefore skip) frames from the source. |
| */ | ||
| pFrame = avcodec_alloc_frame (); | ||
| // RGB: | ||
| pFrameRGB = avcodec_alloc_frame (); // current frame | ||
| for (int j=0;j<this->interval; j++){ |
|
@a-tze : Thanks.. you're right it is some obsolete code. Will delete and update. Even without that I'm not sure dividing the frame into 9 sections is better. Test cases(custom put together videos) will be hard to construct. |
|
I reviewed this PR. I don't think this is complete.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still needs testing on running and memory leaks.