windows fixes #82
Draft
windows fixes #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksjogo
force-pushed
the
windows-fixes
branch
from
fd85b91 to
14ef998
Compare
ksjogo
force-pushed
the
windows-fixes
branch
3 times, most recently
from
9e8d117 to
540523f
Compare
|
Should be good to go know (after #57) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs #57 for project based tests.
This PR reworks most of the path handling to be able to function cross platform.
It isn't perfect yet, but it now allows ts2gd to be run on Windows and I could successfully transpile the full bloodfever project.
I also had to rework the Asset class structure to be able to better share path handling between places.