Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition S1 SLC processing for InSAR coherence, Dual-pol H-Alpha and backscatter #152

Open
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

jmarkloew
Copy link

No description provided.

@johntruckenbrodt johntruckenbrodt marked this pull request as draft October 13, 2021 15:19
@johntruckenbrodt
Copy link
Owner

Hi @jmarkloew. The function S1_HA_proc exists twice. Is that intended?

@johntruckenbrodt
Copy link
Owner

For the time being I converted this PR to a draft (in hopes of disabling all the CI tests for now), we'll reactivate it once ready.

@jmarkloew
Copy link
Author

Fine by me. No the doubling of a function was not intended. this looks like a copy and paste error to me ;) I'll provide the intended code asap

@johntruckenbrodt
Copy link
Owner

Hi @jmarkloew. Next thing on the list is directory concatenation..
Instead of this:

tmpdir + "/" + sensor

always do this:

import os
os.path.join(tmpdir, sensor)

Please adjust your code accordingly. This is essential for running the code on Windows (where the separator is \\ instead of /).

@johntruckenbrodt johntruckenbrodt marked this pull request as ready for review September 9, 2022 08:21
fps_lst = [info.scene]
info = [info]
elif isinstance(infiles, list):
info = pyroSAR.identify_many(infiles, verbose=False, sortkey='start')
Copy link

@mmarionncern mmarionncern Sep 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a SAR expert, but at least I can point few bugs on top of pyroSAR v0.18.0

verbose variable does not exists on pyroSAR.identify_many

else:
raise RuntimeError("Please provide a valid filepath")

final_out_fp = os.path.join(out_dir_p, tpm_name)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be os.path.join(out_dir_fp, tpm_name)

tc.parameters["pixelSpacingInMeter"] = t_res
tc.parameters["mapProjection"] = t_crs
tc.parameters["saveSelectedSourceBand"] = True
tc.parameters["outputComplex"] = False

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that "outputComplex" key does not exists in the Terrain-Correction node

@johntruckenbrodt johntruckenbrodt mentioned this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants