Merge pull request #901 from zghosts/feature/a11y

Feature/a11y
joindin · Aug 24, 2020 · 87db40e · 87db40e
2 parents c43e4e4 + db972f0
commit 87db40e
Show file tree

Hide file tree

Showing 13 changed files with 2,708 additions and 1,399 deletions.
diff --git a/app/templates/Event/_common/event_header.html.twig b/app/templates/Event/_common/event_header.html.twig
@@ -1,7 +1,7 @@
 <div class="page-header">
     <div class="row event">
         <div class="col-xs-12 col-sm-2 logo text-center">
-            <img src="{{ event.getSmallImage }}">
+            <img src="{{ event.getSmallImage }}" alt="{{ event.getName }}">
         </div>
         <div class="col-xs-12 col-sm-10 title">
             <h1>

diff --git a/app/templates/Event/_common/summary.html.twig b/app/templates/Event/_common/summary.html.twig
@@ -8,7 +8,7 @@ set eventUrl = urlFor(
     <div class="col-xs-12">
         <div class="logo text-center">
             <a href="{{ eventUrl }}">
-                <img src="{{ event.getSmallImage }}">
+                <img src="{{ event.getSmallImage }}" alt="{{ event.getName }}">
             </a>
         </div>
         <div class="title">

diff --git a/app/templates/_common/login.html.twig b/app/templates/_common/login.html.twig
@@ -7,11 +7,11 @@
     {% endif %}
     <div class="form-group">
         <label for="username">Username:</label>
-        <input type="text" class="form-control" name="username">
+        <input id="username" type="text" class="form-control" name="username">
     </div>
     <div class="form-group">
         <label for="password">Password:</label>
-        <input type="password" class="form-control" name="password">
+        <input id="password" type="password" class="form-control" name="password">
     </div>
     <div class="form-group">
         <input type="submit" class="btn btn-primary" value="Log in">

diff --git a/app/templates/layout.html.twig b/app/templates/layout.html.twig
@@ -2,7 +2,7 @@
 {% if not sidebar_col_width %} {% set sidebar_col_width = 3 %} {% endif %}
 {% set main_col_width = 12 - sidebar_col_width %}
 <!DOCTYPE html>
-<html>
+<html lang="en">
 <head>
     <meta charset="utf-8">
     <title>{% block title %}Joind.in{% endblock %}</title>