Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing for direct send rpc api #809

Draft
wants to merge 3 commits into
base: devel
Choose a base branch
from

Conversation

amitx13
Copy link
Contributor

@amitx13 amitx13 commented Aug 11, 2024

This PR aims to test the Direct-Send RPC API to ensure compatibility with recent changes. The key updates include modifications to the selected_utxos parameter.

image
@theborakompanioni could you please test the changes and confirm that they do not introduce any issues with Jam? Your confirmation will allow us to proceed with JoinMarket-Org/joinmarket-clientserver#1721 PR.

Disclaimer
Please do not merge this PR. The purpose of this PR is solely to test the changes and ensure compatibility. It is not intended for merging into the main codebase.

@amitx13 amitx13 added the blocked Merging this pull request is blocked until another issue is resolved label Aug 11, 2024
@amitx13 amitx13 self-assigned this Aug 11, 2024
@amitx13 amitx13 added the RPC-API A feature or functionality that aims to modify Joinmarket api's label Aug 11, 2024
@theborakompanioni
Copy link
Collaborator

First simple tests have been successful.
As this is not intended to be merged, I'll convert it to a "draft PR".

Will let you know once I have made further progress. Looks promising 🚀

@theborakompanioni theborakompanioni marked this pull request as draft August 12, 2024 14:55
@theborakompanioni
Copy link
Collaborator

Hey @amitx13! Thanks for PR - it was quite nice testing the changes with the code you provided.
I have answered in the server PR here: JoinMarket-Org/joinmarket-clientserver#1721 (comment)

@amitx13
Copy link
Contributor Author

amitx13 commented Aug 21, 2024

Hey @theborakompanioni Thanks for testing and reviewing the PR. Appreciate the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Merging this pull request is blocked until another issue is resolved RPC-API A feature or functionality that aims to modify Joinmarket api's
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants