Fix super class의 필드 접근 못하는 이슈 해결 #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wordbe
reviewed
Apr 12, 2024
Comment on lines
+44
to
60
| final Class<?> itemClass = item.getClass(); | ||
| if (itemClass.getSuperclass() != null) { | ||
| final Class<?> superclass = itemClass.getSuperclass(); | ||
| final Field[] superClassFields = superclass.getDeclaredFields(); | ||
| for (Field field : superClassFields) { | ||
| if (field.getName().equals(fieldName)) { | ||
| field.setAccessible(true); | ||
| superclass.getDeclaredField("id"); | ||
| return field.get(item); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| final Field field = itemClass.getDeclaredField("id"); | ||
| field.setAccessible(true); | ||
| return field.get(item); | ||
| } catch (NoSuchFieldException | IllegalAccessException e) { |
There was a problem hiding this comment.
Suggested change
| final Class<?> itemClass = item.getClass(); | |
| if (itemClass.getSuperclass() != null) { | |
| final Class<?> superclass = itemClass.getSuperclass(); | |
| final Field[] superClassFields = superclass.getDeclaredFields(); | |
| for (Field field : superClassFields) { | |
| if (field.getName().equals(fieldName)) { | |
| field.setAccessible(true); | |
| superclass.getDeclaredField("id"); | |
| return field.get(item); | |
| } | |
| } | |
| } | |
| final Field field = itemClass.getDeclaredField("id"); | |
| field.setAccessible(true); | |
| return field.get(item); | |
| } catch (NoSuchFieldException | IllegalAccessException e) { | |
| protected Object getFieldValue(T item) { | |
| try { | |
| Class<?> itemClass = item.getClass(); | |
| while (itemClass != null) { | |
| Field[] fields = itemClass.getDeclaredFields(); | |
| for (Field field : fields) { | |
| if (field.getName().equals(fieldName)) { | |
| field.setAccessible(true); | |
| return field.get(item); | |
| } | |
| } | |
| itemClass = itemClass.getSuperclass(); | |
| } | |
| throw new IllegalAccessException(fieldName); | |
| } catch (IllegalAccessException e) { | |
| log.error("Not Found or Not Access Field: " + fieldName, e); | |
| throw new IllegalArgumentException("Not Found or Not Access Field"); | |
| } | |
| } |
여러 부모를 상속할 수 있기 때문에 위와 같은 코드를 제안드립니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
증상
Error Log
자세히
해결
해당 클래스가 슈퍼 클래스를 상속 받으면 해당 필드를 슈퍼 클래스에서 찾고 없으면 기존 코드의 자신의 필드에서 찾게 변경