-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix refinedet trt8 #1329
Fix refinedet trt8 #1329
Conversation
8a6d5ff
to
de7fed9
Compare
d3fdad7
to
a3c252a
Compare
CMakeLists.txt
Outdated
@@ -916,26 +916,22 @@ if (USE_TENSORRT) | |||
set(TENSORRT_INC_DIR /usr/include/x86_64-linux-gnu) | |||
endif() | |||
|
|||
if (NOT EXISTS "${TRTTESTDIR}/libnvinfer.so.7") | |||
if (NOT EXISTS "${TRTTESTDIR}/libnvinfer.so.8") | |||
message(FATAL_ERROR "Could not find TensorRT ${TENSORRT_LIB_DIR}/libnvinfer.so.7, please provide tensorRT location as TENSORRT_DIR or (TENSORRT_LIB_DIR _and_ TENSORRT_INC_DIR)") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
libnvinfer.so.8
instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was already done, not pushed, sorry
a3c252a
to
f5ab681
Compare
f5ab681
to
ae9ce15
Compare
@fantes I do confirme the docker does build with the latest NVidia+tensorrt container image, patch is below that could be integrated to this PR: diff --git a/docker/gpu_tensorrt.Dockerfile b/docker/gpu_tensorrt.Dockerfile
index 59ce5317..03de8d62 100644
--- a/docker/gpu_tensorrt.Dockerfile
+++ b/docker/gpu_tensorrt.Dockerfile
@@ -1,5 +1,5 @@
# syntax = docker/dockerfile:1.0-experimental
-FROM nvcr.io/nvidia/tensorrt:21.04-py3 AS build
+FROM nvcr.io/nvidia/tensorrt:21.07-py3 AS build
ARG DEEPDETECT_RELEASE=OFF
ARG DEEPDETECT_ARCH=gpu
@@ -110,7 +110,7 @@ RUN --mount=type=cache,target=/ccache/ mkdir build && cd build && ../build.sh
RUN ./docker/get_libs.sh
# Build final Docker image
-FROM nvcr.io/nvidia/tensorrt:21.04-py3 AS runtime
+FROM nvcr.io/nvidia/tensorrt:21.07-py3 AS runtime
ARG DEEPDETECT_ARCH=gpu |
CMakeLists.txt
Outdated
if (EXISTS "${TRTTESTDIR}/libnvinfer.so.8") | ||
set(TENSORRT_VERSION 21.08) | ||
message(STATUS "Found TensorRT libraries version 8.x") | ||
elseif (EXISTS "${TRTTESTDIR}/libnvinfer.so.8") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the same test twice, no ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right, fixed
ae9ce15
to
22e7b08
Compare
At the moment, several models appear to be broken:
|
469b066
to
e166442
Compare
e166442
to
01b54d7
Compare
This PR addresses #1324
it also updates dependencies to TRT 8.x
BIG FAT WARNING :
TRT 8.0.1.x is subject to this bug : https://forums.developer.nvidia.com/t/build-engine-error-when-use-pointnet-like-structure-and-tensorrt-8-0-1-6/183569, which makes ssd models not working !!!