Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added key overflow warning at end of db serialization when an image key > 256 chars #755

Merged
merged 1 commit into from
Jul 20, 2020
Merged

Added key overflow warning at end of db serialization when an image key > 256 chars #755

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/backends/caffe/caffeinputconns.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,6 +369,7 @@ namespace dd
int count = 0;
const int kMaxKeyLength = 256;
char key_cstr[kMaxKeyLength];
bool key_overflow = false;

for (int line_id = 0; line_id < (int)lfiles.size(); ++line_id) {
Datum datum;
Expand All @@ -388,7 +389,9 @@ namespace dd
// sequential
int length = snprintf(key_cstr, kMaxKeyLength, "%08d_%s", line_id,
lfiles[line_id].first.c_str());

if (lfiles[line_id].first.size() > kMaxKeyLength)
key_overflow = true;

// put in db
std::string out;
if(!datum.SerializeToString(&out))
Expand All @@ -407,6 +410,9 @@ namespace dd
txn->Commit();
_logger->info("Processed {} files",count);
}
if (key_overflow)
_logger->warn("Some of the keys in {} have been truncated to fit the 256 max key length requirement",
dbfullname);
}

void ImgCaffeInputFileConn::write_image_to_db_multilabel(const std::string &dbfullname,
Expand All @@ -425,6 +431,7 @@ namespace dd
int count = 0;
const int kMaxKeyLength = 256;
char key_cstr[kMaxKeyLength];
bool key_overflow = false;

for (int line_id = 0; line_id < (int)lfiles.size(); ++line_id) {
Datum datum;
Expand All @@ -449,6 +456,8 @@ namespace dd
// sequential
int length = snprintf(key_cstr, kMaxKeyLength, "%08d_%s", line_id,
lfiles[line_id].first.c_str());
if (lfiles[line_id].first.size() > kMaxKeyLength)
key_overflow = true;

// put in db
std::string out;
Expand All @@ -468,6 +477,9 @@ namespace dd
txn->Commit();
_logger->info("Processed {} files",count);
}
if (key_overflow)
_logger->warn("Some of the keys in {} have been truncated to fit the 256 max key length requirement",
dbfullname);
}

// - fixed size in-memory arrays put down to disk at once
Expand Down