fix: build with -DUSE_TENSORRT_OSS=ON #813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We still should check for proper CUDA 10.2 for builds with |
fantes
approved these changes
Sep 16, 2020
CMakeLists.txt
Outdated
| @@ -889,9 +889,9 @@ if (USE_TENSORRT) | |||
| set(TENSORRT_LIBS protobuf nvinfer nvparsers nvinfer_plugin nvonnxparser ) | |||
|
|
|||
| else() | |||
| set(TENSORRT_LIB_DIR ${CMAKE_BINARY_DIR}/tensorrt-oss/src/tensorrt-oss-build ${TENSORRT_LIB_DIR}) | |||
| set(TENSORRT_LIB_DIR ${CMAKE_BINARY_DIR}/tensorrt-oss/src/tensorrt-oss-build ${CMAKE_BINARY_DIR}/tensorrt-oss/bin/ ${TENSORRT_LIB_DIR}) | |||
There was a problem hiding this comment.
I think ${CMAKE_BINARY_DIR}/tensorrt-oss/src/tensorrt-oss-build can be dropped as everything should be built/installed in ${CMAKE_BINARY_DIR}/tensorrt-oss/bin/ because of -DTRT_OUT_DIR=${CMAKE_BINARY_DIR}/tensorrt-oss/bin set some lines below
There was a problem hiding this comment.
Good intuition! the build goes through when removing this path, I've updated the commit.
beniz
force-pushed
the
fix_tensorrt_oss_build
branch
from
23a480c
to
0c66725
Compare
Sets Jenkins to build with TENSORRT_OSS as default since it's now the most recent and advanced.
beniz
force-pushed
the
fix_tensorrt_oss_build
branch
from
0c66725
to
545bc79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets Jenkins to build with TENSORRT_OSS as default since it's now the
most recent and advanced.