Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow jolo-like did methods with a different prefix #441

Open
wants to merge 2 commits into
base: next
Choose a base branch
from
Open

allow jolo-like did methods with a different prefix #441

wants to merge 2 commits into from

Conversation

chunningham
Copy link
Contributor

allows for DID methods with the same architecture as did:jolo but a different anchoring network to easily integrate with the library

Exulansis
Exulansis requested changes Nov 16, 2020
View reviewed changes
Copy link
Collaborator

@Exulansis Exulansis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
This could use a test or two to ensure that the correct DID prefix is propagated (e.g. across created DID Documents, Signed Credentials, as part of recovery). Especially to ensure we don't accidentally break this functionality later.

@mnzaki mnzaki closed this Mar 10, 2021
@mnzaki mnzaki deleted the branch next March 10, 2021 10:21
@mnzaki mnzaki reopened this Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Exulansis Exulansis Exulansis requested changes

@mnzaki mnzaki Awaiting requested review from mnzaki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chunningham @Exulansis @mnzaki