Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter resources by topic #2

Open
wants to merge 5 commits into
base: feature/resource-page
Choose a base branch
from

Conversation

jordan-choi
Copy link
Owner

This is a:

  • New feature - new behaviour has been implemented
  • 🐛 Bug fix - existing behaviour has been made to behave
  • ♻️ Refactor - the behaviour has not changed, just the implementation
  • Test backfill - tests for existing behaviour were added but the behaviour itself hasn't changed
  • ⚙️ Chore - maintenance task, behaviour and implementation haven't changed

Description

  • Purpose - allow topic-based filtering for resources

  • Changes Implemented

    • Added a new FilterTagList component to the Resources page
    • Implemented multi-select functionality for topic tags
    • Modified the resource list to dynamically update based on selected topics
    • Updated the /api/resources endpoint to accept and process topic filter parameters
  • How to check -

    • Visit the "Resources" page. There should be a new Tag list at the top of the page.
    • Click one or more tags and observe that the resource list updates in real-time to reflect the selected topics
    • Select all tags and verify the behavior
    • Deselect all tags and ensure the full list of resources is displayed
    • Review the API docs, /api/resources endpoint descriptions should match the observed behaviour
  • Additional Notes

    • There was no specific design provided for this feature. As a result, I implemented it using a basic Tag component, which has been developed at a minimum functional level.
    • The current implementation focuses on core functionality rather than advanced styling or complex interactions.

Links

CodeYourFuture#30

Author checklist

  • I have written a title that reflects the relevant ticket
  • I have written a description that says what the PR does and how to validate it
  • I have linked to the project board ticket (and any related PRs/issues) in the Links section
  • I have added a link to this PR to the ticket
  • I have made the PR to main from a branch named <category>/<name>, e.g. feature/edit-spaceships or bugfix/restore-oxygen
  • I have manually tested that the app still works correctly
  • I have requested reviewers here and in my team chat channel
  • I have spoken with my PM or TL about any parts of this task that may have become out-of-scope, or any additional improvements that I now realise may benefit my project
  • I have added tests, or new tests were not required
  • I have updated any documentation (e.g. diagrams, schemas), or documentation updates were not required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant