-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support powerful and econo modes #9
base: main
Are you sure you want to change the base?
Conversation
this is working only for some units, should we make this in someway conditional? |
Added has_preset config option in 605db07 |
@@ -30,6 +31,7 @@ | |||
cv.Optional( | |||
CONF_SETPOINT_INTERVAL, default="300s" | |||
): cv.positive_time_period_seconds, | |||
cv.Optional(CONF_HAS_PRESETS, default=True): cv.boolean, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Defaulting to True
here is backwards-incompatible and will break existing configs for some units. For instance, my units do not support the F6/F7 queries (even though they do support powerful mode). As a result, building my existing configs with this change causes the unit to report incorrect data to Home Assistant, but setting this to false fixes the issue.
An alternative would be some sort of graceful degradation in the event presets do not work, though that would require some reworking of how the module elects which queries to use. This would be a worthwhile/valuable enhancement in general, as I suspect there are going to be more cases where different queries are required, but I don't expect that in this PR.
I was recently working on this independent of this pull request and I also found that my unit won't accept what's sent in D6/D7 (F6/F7) queries. Interestingly, if I change the preset via remote, it will correctly report back powerful or eco mode. I was thinking that maybe it could be toggled via YAML? |
Seems like this PR would benefit from merging with changes in #11 which adds the concept of failable queries? |
@wrouesnel Maybe for some units? My FTXC-D responds with success to these queries but it doesn't change the mode (it returns 0x00s in the packet). Alhough it does report the correct mode when I change it with IR remote. However, the pull requests are in conflict with their queries array which would have to be addressed when merging. All in all, I think there's still too many unknowns in S21 protocol to correctly implement everything for all units. In the end, I resorted to capturing the IR signals sent by original remote and implementing that in a custom ESPHome component. That way, I also get econo+sleep mode (while I couldn't find any reference to the sleep mode in reverse engineered S21 docs at all). |
By comparison to the ESP32-Faikin project, if you look at https://github.com/revk/ESP32-Faikin/blob/d1c87cdb4c49ee9d6dd9d10e5c863b9341edeae4/ESP32/main/Faikin.c#L416 then it looks like it's possible that the mode change on your might actually be reported as "G3". When I run debug protocol on the unit I have access to This is a unit at my parents place so I'm not sitting in front of it with the remote, but I'll see if I can map out what's happening - it's possible your issues are just that the response codes are all over the place (if it works I'll borrow the work here and try and see if using it in #11 can make it reliable).
|
I think I didn't experiment with F3, but, as I said, my AC won't change the mode when sending F5/F6, but it will report back powerful mode in G5/G6 if set on remote. I'm sitting right next to it when experimenting so I'd know if it reacted to the command. But, even if F3 would set powerful mode, it won't set eco mode according to Faikin's code, and there's no documented way to enable sleep mode at all, which is a must for me (sleep+eco mode can be enabled with original IR remote). I got a B45 adapter which is listed as compatible with FTXC-D, but the problem is that it doesn't offer powerful/eco/sleep modes, they're missing from both the old and the new Daikin Android app - so I can't capture the command that it would send. I read somewhere that some adapters don't offer all features, so maybe B41 or B42 would do the trick, but at the prices of 40-50 euros/dollars per adapter, I don't plan on spending a small fortune on experimenting when a 50 cent IR diode soldered to ESP8266 does the trick. Unless someone wants to trade their extra adapter for my B45. |
No description provided.