-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix versioning. Remove objMap. #243
Open
brucen1030
wants to merge
94
commits into
journeymidnight:master
Choose a base branch
from
brucen1030:wip_fix_versioning
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…time columns into buckets table.
Change some names, import and log style.
Improve performace of listing objects
Signed-off-by: sunfch <[email protected]>
Improve performace of listing object
Signed-off-by: sunfch <[email protected]>
Set the number of query result 10000
fix the problem of start job to sync bucket usage.
fix the problem of removing wrong key when perform bucket delete.
Signed-off-by: sunfch <[email protected]>
Signed-off-by: sunfch <[email protected]>
Signed-off-by: sunfch <[email protected]>
brucen1030
force-pushed
the
wip_fix_versioning
branch
from
February 20, 2020 01:39
26f0c37
to
18c8865
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with test/versioning.py
Objects in versioned buckets are not appendable.
Versioning is handled as follows.
And responsed to client with converted versionId in meta/client/tidbclient/object.go
TODO work
https://docs.aws.amazon.com/AmazonS3/latest/dev/intro-lifecycle-rules.html#intro-lifecycle-rules-actions