Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NvOFInstanceD3D12: Implement input/output fence points #222

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

liam-middlebrook
Copy link
Contributor

Needed for older versions of nvngx_dlssg.dll where OF buffer registration was synchronized with GPU work.

Needed for older versions of nvngx_dlssg.dll where OF buffer
registration was synchronized with GPU work.
@liam-middlebrook
Copy link
Contributor Author

Thanks to @adamdmoss for reporting this bug. If you're able to confirm this resolves your issue I'd appreciate it.

@adamdmoss
Copy link

adamdmoss commented Nov 7, 2024

Gollum is very happy with this PR. Thanks!

@adamdmoss
Copy link

Oh, it fixes the rat game crash too! Hooray! It has weird unpleasant out-of-order frame issues when FG is enabled but that's better than being in a crashloop.

@adamdmoss
Copy link

Gollum is very happy with this PR. Thanks!

Oops, spoke too soon. It has the same problem as Plague Tale Requiem with this fix; it no longer crashes but it eventually starts presenting frames out-of-order. Just took longer to repro (like a couple of minutes) with Gollum.

@adamdmoss
Copy link

So -> IMHO this fix is a definite improvement (visual glitches are an improvement over complete crashing) and I'd love it to land, but it either reveals or causes further issues with the two titles it stops crashing so it's not an ultimate fix.

@jp7677
Copy link
Owner

jp7677 commented Nov 8, 2024

@liam-middlebrook Do you want to address Adams remaining points as part of this PR (if it is even doable here) or do you prefer if we land this now as an intermediate improvement?

@liam-middlebrook
Copy link
Contributor Author

@liam-middlebrook Do you want to address Adams remaining points as part of this PR (if it is even doable here) or do you prefer if we land this now as an intermediate improvement?

I don't think we should wait for that. There are a few different modules at work here, and the issues Adam describes don't sound like they would be due to nvofapi64.dll.

@jp7677 jp7677 merged commit b1a0a6a into jp7677:master Nov 8, 2024
4 checks passed
@jp7677
Copy link
Owner

jp7677 commented Nov 8, 2024

Thanks!

@liam-middlebrook liam-middlebrook deleted the ofa-d3d12-register-sync branch November 13, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants