Use COM template #224
Merged
Use COM template #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jp7677
force-pushed
the
move-resource-factory
branch
2 times, most recently
from
6e5e732 to
745bba4
Compare
Saancreed
approved these changes
Nov 9, 2024
tests/meson.build
Outdated
| @@ -2,6 +2,7 @@ nvapi_src = files([ | |||
| '../src/util/util_string.cpp', | |||
| '../src/util/util_env.cpp', | |||
| '../src/util/util_log.cpp', | |||
| '../src/nvapi/resource_factory.cpp', | |||
Also change member order to ensure deconstruction (and thus release) in the original order.
jp7677
force-pushed
the
move-resource-factory
branch
from
745bba4 to
5434f06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should take care of calling
Release(). The members have been reordered to ensure that release order doesn't change.While at it, also move
ResourceFactorytonvapi, I don't see us sharing this since it would pullnvmlandlfxintonvofapi.