Export include path using target_include_directories #82
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I was using your project from an external CMake project, and I notice that the directories of the target are not exported to other projects that include yours as
add_subdirectory
and then usetarget_link_libraries
.For example, in a basic CMake example using your library:
I'm not be able to use the curlpp includes. (More exaclty, the gcc does not compile with the
-Ipath-to-curlpp
)Adding the
target_include_directories
in your CMake library allows to add the curlpp includes path to the compilation when you link against the library attarget_link_libraries
.I let you know the change in case you want to incorporate it into your project.
Regards.