New Array serializer and changes to existing Json serializer #97
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I had a requirement to $User->to_array() and $User->attributes() wasn't appropriate in the particular scenario because I wanted to exclude the password attribute and I didn't want to override attributes(), so I override to_array() in User like so: -
As the Json and Array serialization code is mostly the same, I made the Json serializer extend the Array serializer. Not sure if that's the best approach, but it made the code more DRY.
Commit - https://github.com/asha79/php-activerecord/commit/b669e413b198aceae03075988e5b9fcfd7338092
Ash.