Fix/harata ranking today #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubosaka
reviewed
Nov 15, 2024
| status: 404, | ||
| if (!scores[0]?.assignment){ | ||
| return new Response(JSON.stringify({}), { | ||
| status: 200, |
Comment on lines
66
to
68
| if (selectedTopic !== 0) { | ||
| fetchData(getDate()); | ||
| } |
There was a problem hiding this comment.
トピックが0の時（今日のお題がない時）、ローディングが消えないので、対応お願いします
Suggested change
| if (selectedTopic !== 0) { | |
| fetchData(getDate()); | |
| } | |
| if (selectedTopic !== 0) { | |
| fetchData(getDate()); | |
| } | |
| setIsLoading(false); |
TkymHrt
reviewed
Nov 15, 2024
Comment on lines
75
to
84
| if (!Array.isArray(data) || data.length === 0) { | ||
| return ( | ||
| <div | ||
| className="flex items-center justify-center h-40 text-lg text-orange-500" | ||
| > | ||
| まだ投稿がありません！<br /> | ||
| 1位になれるかも! | ||
| </div> | ||
| ); | ||
| } |
There was a problem hiding this comment.
cameraページへ遷移するボタンも置いておくのはどうでしょうか？
(文字サイズと間隔も調整してみました。)
Suggested change
| if (!Array.isArray(data) || data.length === 0) { | |
| return ( | |
| <div | |
| className="flex items-center justify-center h-40 text-lg text-orange-500" | |
| > | |
| まだ投稿がありません！<br /> | |
| 1位になれるかも! | |
| </div> | |
| ); | |
| } | |
| if (!Array.isArray(data) || data.length === 0) { | |
| return ( | |
| <div className="flex flex-col items-center justify-center h-full text-lg text-gray-700 mt-[20vh]"> | |
| <p className="text-2xl font-bold mb-4">まだ投稿がありません</p> | |
| <p className="mb-4">今すぐ投稿して1位を目指しましょう！</p> | |
| <p className="text-gray-800 mb-4"> | |
| あなたの投稿がトップに表示されるかも！ | |
| </p> | |
| <Button | |
| variant="primary" | |
| className="flex items-center justify-center w-3/5 bg-gray-800 hover:bg-gray-700 text-white py-6 space-x-2 mt-4" | |
| onClick={() => router.push("/camera")} | |
| > | |
| <PhotoCameraIcon className="w-6 h-auto" /> | |
| <span className="text-lg font-semibold">写真を撮る</span> | |
| </Button> | |
| </div> | |
| ); | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
スコアがないお題とスコアがあるお題が存在する場合、スコアがないお題にはスコアがあるお題のランキングが表示されている変更内容
動作確認
関連するIssue
#123備考