Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Half closing of connections when CloseWrite() is available #536

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Half closing of connections when CloseWrite() is available #536

wants to merge 1 commit into from

Commits on Oct 23, 2024

  1. Half closing of connections when CloseWrite() is available 

    Clean termination when FIN received on one side but there's data remaining to send from the other side.

Fixes an issue discovered in a reverse scenario (client -> chiselServer -> chiselClient -> server), where the client would close connection after sending data, but before the server has finished sending data.
Without Chisel, same situation, the server is delaying the close because it still wants to send data, and it closes after having sent it.
With Chisel, chiselServer was closing the connection immediately first, preventing the server to send its remaining data.
    @liojacqs
    liojacqs committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    92ffb69 View commit details
    Browse the repository at this point in the history