Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output instance specific options #16

Closed
herndlm opened this issue Aug 25, 2021 · 2 comments
Closed

Output instance specific options #16

herndlm opened this issue Aug 25, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@herndlm
Copy link
Contributor

herndlm commented Aug 25, 2021

I was thinking of making my instance available for the public too, if there are more they could potentially even be listed in the README so that users can choose one. I think it would be good then if the bot could output instance specific options so that the users know if it's up-to-date or configured as they would like to use it, e.g.

  • check_interval: maybe via feeds command as in "The feeds are checked for updates every {check_interval} seconds"
  • version: this is the most interesting one IMO but also tricky as the version only exists in setup.cfg and via git tag. Maybe the former could be loaded/parsed or migrated to setup.py if that helps? Either a dedicated version or status command might make sense, or simply adding it to help

What do you think?

I wanted to implement the first one already but failed with generating the translations correctly, if you are interested in it I can create PRs if you point me in the right directions :)

@jplitza jplitza added the enhancement New feature or request label Aug 31, 2021
@jplitza
Copy link
Owner

jplitza commented Aug 31, 2021

Both are nice ideas. I'm opposed to adding another command, however. The interval in "feeds" and the version in "help" sounds fine.

The translations are done with gettext. I didn't master that myself, yet. It's probably easiest to simply add the necessary lines to the nina_xmpp/locale/nina_xmpp.pot and nina_xmpp/locale/de/LC_MESSAGES/nina_xmpp.po files manually...

@herndlm
Copy link
Contributor Author

herndlm commented Aug 31, 2021

Great, I'll create a PR for that then soon!

I was playing around with gettext but did not get it to generate the files the right way..

herndlm added a commit to herndlm/nina_xmpp that referenced this issue Sep 1, 2021
herndlm added a commit to herndlm/nina_xmpp that referenced this issue Sep 1, 2021
@jplitza jplitza closed this as completed in f8886c1 Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants