Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output check_interval via feeds command #18

Merged
merged 2 commits into from
Oct 6, 2021
Merged

Output check_interval via feeds command #18

merged 2 commits into from
Oct 6, 2021

Conversation

herndlm
Copy link
Contributor

@herndlm herndlm commented Sep 1, 2021 •
edited
Loading

Part of #16

jplitza
jplitza requested changes Sep 4, 2021
View reviewed changes
Copy link
Owner

@jplitza jplitza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update nina_xmpp/locale/nina_xmpp.pot with the new translation strings.

Since obtaining the version might prove difficult (see line comment), it might make sense to split off the interval info into its own PR.

nina_xmpp/__main__.py Outdated Show resolved Hide resolved
nina_xmpp/__init__.py Show resolved Hide resolved
@herndlm
Copy link
Contributor Author

herndlm commented Oct 6, 2021 •
edited
Loading

Please also update nina_xmpp/locale/nina_xmpp.pot with the new translation strings.

Since obtaining the version might prove difficult (see line comment), it might make sense to split off the interval info into its own PR.

Updated, sorry for the delay

@herndlm herndlm requested a review from jplitza October 6, 2021 07:45
@herndlm herndlm changed the title Output instance specific options Output check_interval via feeds command Oct 6, 2021
@jplitza jplitza merged commit f8886c1 into jplitza:master Oct 6, 2021
@herndlm herndlm deleted the feature/output-instance-specific-options branch January 28, 2022 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jplitza jplitza Awaiting requested review from jplitza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@herndlm @jplitza