Support breakpoints when iPadOS window frame size changes #209
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
It seems that this change requires min. Expo SDK 50 and React Native 0.73. |
|
Apart from that works great!
|
Oh nice catch! Thanks for the quick merge! |
|
Released as 2.8.0-beta.1 |
|
I've been running the beta since the PR merged and this has been working mostly great! There's a small bug I've noticed where minimizing the app on an ipad and then opening it again shows my "mobile" UI before flipping back to the correct breakpoint. So it seems like as the app window is animating while closing/opening unistyles is able to handle I'll see if I can find some time this week to see if there's anything we can use to ignore events while the app is being minimized/maximized as that should fix the jank when bringing an app back to the foreground. |
As of version 2.8.0 that includes this PR jpudysz#209 (comment), React Native 0.73 is the minimum supported.
Summary
Fixes #208
I'm not an iOS developer, but I thought I'd take a stab at figuring out how to handle the iPadOS window frame sizing. I thought it'd be best to do it in a way that works across all iOS products to keep the code simple.
I think the solution here ended up being fairly clean and I was able to test on a physical iPad and an iPhone simulator to validate the breakpoints are working as intended on both operating systems.