Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support visionos with new core #217

Merged
merged 1 commit into from
Jun 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .eslintrc
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,8 @@
"functional/immutable-data": 0,
"no-underscore-dangle": 0,
"max-lines": 0
}
},
"ignorePatterns": [
"examples/vision/visionos"
]
}
4 changes: 2 additions & 2 deletions examples/bare/ios/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -935,7 +935,7 @@ PODS:
- React-Mapbuffer (0.74.2):
- glog
- React-debug
- react-native-unistyles (2.8.0-rc.1):
- react-native-unistyles (2.8.0-rc.3):
- DoubleConversion
- glog
- hermes-engine
Expand Down Expand Up @@ -1395,7 +1395,7 @@ SPEC CHECKSUMS:
React-jsitracing: 0fa7f78d8fdda794667cb2e6f19c874c1cf31d7e
React-logger: 29fa3e048f5f67fe396bc08af7606426d9bd7b5d
React-Mapbuffer: bf56147c9775491e53122a94c423ac201417e326
react-native-unistyles: ad905f21fdab6f22a82d33fc89af09d2a0204e52
react-native-unistyles: b1c5a0d1f66e07747c8ee0069ef329db831b0ef8
React-nativeconfig: 9f223cd321823afdecf59ed00861ab2d69ee0fc1
React-NativeModulesApple: ff7efaff7098639db5631236cfd91d60abff04c0
React-perflogger: 32ed45d9cee02cf6639acae34251590dccd30994
Expand Down
1 change: 1 addition & 0 deletions examples/expo/src/components/StyleSheetBox.tsx
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import React from 'react'
import { StyleSheet, View } from 'react-native'

export const StyleSheetBox = () => (
Expand Down
1 change: 1 addition & 0 deletions examples/vision/assets/Bird.tsx
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import React from 'react'
import Svg, { Path } from 'react-native-svg'

export const Bird = () => (
Expand Down
1 change: 1 addition & 0 deletions examples/vision/assets/Cloud.tsx
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import React from 'react'
import Svg, { Path, Defs, RadialGradient, Stop } from 'react-native-svg'

export const Cloud = () => (
Expand Down
1 change: 1 addition & 0 deletions examples/vision/assets/Moon.tsx
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import React from 'react'
import Svg, { Path } from 'react-native-svg'

export const Moon = () => (
Expand Down
1 change: 1 addition & 0 deletions examples/vision/assets/Star.tsx
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import React from 'react'
import Svg, { Path } from 'react-native-svg'

export const Star = () => (
Expand Down
1 change: 1 addition & 0 deletions examples/vision/assets/Sun.tsx
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import React from 'react'
import Svg, { Circle, Defs, RadialGradient, Stop } from 'react-native-svg'

export const Sun = () => (
Expand Down
2 changes: 1 addition & 1 deletion examples/vision/metro.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ const config = {
extraNodeModules: modules.reduce((acc, name) => ({
...acc,
[name]: path.join(__dirname, 'node_modules', name)
}), {}),
}), {})
// resolveRequest: getPlatformResolver({
// platformNameMap: { visionos: '@callstack/react-native-visionos' }
// })
Expand Down
36 changes: 18 additions & 18 deletions examples/vision/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,27 +9,27 @@
"start": "npx @callstack/react-native-visionos start"
},
"dependencies": {
"@callstack/react-native-visionos": "0.73.10",
"react": "18.2.0",
"react-native": "0.73.6",
"react-native-svg": "15.1.0"
"@callstack/react-native-visionos": "0.74.3",
"react": "18.3.1",
"react-native": "0.74.2",
"react-native-svg": "15.3.0"
},
"devDependencies": {
"@babel/core": "7.24.3",
"@babel/preset-env": "7.24.3",
"@babel/runtime": "7.20.0",
"@callstack/out-of-tree-platforms": "0.73.10",
"@react-native/babel-preset": "0.73.19",
"@react-native/eslint-config": "0.73.2",
"@react-native/metro-config": "0.73.3",
"@react-native/typescript-config": "0.73.1",
"@types/react": "18.2.74",
"babel-jest": "29.6.3",
"babel-plugin-module-resolver": "5.0.0",
"eslint": "8.19.0",
"typescript": "5.0.4"
"@babel/core": "7.24.7",
"@babel/preset-env": "7.24.7",
"@babel/runtime": "7.24.7",
"@callstack/out-of-tree-platforms": "0.74.3",
"@react-native/babel-preset": "0.74.84",
"@react-native/eslint-config": "0.74.84",
"@react-native/metro-config": "0.74.84",
"@react-native/typescript-config": "0.74.84",
"@types/react": "18.3.3",
"babel-jest": "29.7.0",
"babel-plugin-module-resolver": "5.0.2",
"eslint": "8.57.0",
"typescript": "5.5.2"
},
"engines": {
"node": ">=18"
"node": ">=20"
}
}
7 changes: 0 additions & 7 deletions examples/vision/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,12 +1,5 @@
{
"extends": "@react-native/typescript-config/tsconfig.json",
"exclude": [
"**/Pods/**",
"node_modules",
"babel.config.js",
"metro.config.js",
"jest.config.js"
],
"references": [
{
"path": "../../"
Expand Down
3 changes: 0 additions & 3 deletions examples/vision/visionos/Podfile
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,6 @@ target 'vision' do

use_react_native!(
:path => config[:reactNativePath],
# todo
# https://github.com/callstack/react-native-visionos/issues/128
:hermes_enabled => false,
# An absolute path to your application root.
:app_path => "#{Pod::Config.instance.installation_root}/.."
)
Expand Down
Loading
Loading