Support unistyles provider with no breaking changes #337
+188
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Are you saying we can use unistyles without prebuilding? |
jpudysz
requested changes
Nov 12, 2024
|
@yousefelgoharyx ping, can you fix the syntax? |
|
Testing now |
|
Changing 1000 boxes with
What a change!! |
|
Letsss gooo 🚀🚀🔥🔥 |
jpudysz
approved these changes
Nov 22, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The current version of Unistyles has a big performance hit in projects where
useStyleshook is used a lot as described in this discussion #240This PR implements the solution mentioned by the author of the discussion but without any breaking changes. You can opt in by adding
UnistylesProviderat the root of your app to get a huge performance gainThanks to the author of the discussion for such a brilliant workaround