Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for SSR and NextJS #50

Merged
merged 6 commits into from
Oct 26, 2023
Merged

Add support for SSR and NextJS #50

merged 6 commits into from
Oct 26, 2023

Conversation

jpudysz
Copy link
Owner

@jpudysz jpudysz commented Oct 25, 2023 •
edited
Loading

Summary

Resolved requested feature mentioned here #49 and here #48

Tasks:

  • replace normalizer from react-native-web
  • adjust useDimensions hook to be runnable on server
  • add demo to example folder
  • double check tests, we should still aim for ~97%
  • double check examples
  • update docs

Test plan

Add ssr folder to example folder and provide a demo of NextJS and SSR

@vercel
Copy link

vercel bot commented Oct 25, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-unistyles-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 26, 2023 9:11am

@jpudysz jpudysz added the enhancement New feature or request label Oct 25, 2023
@jpudysz jpudysz self-assigned this Oct 25, 2023
@jpudysz
Copy link
Owner Author

jpudysz commented Oct 25, 2023

Current test coverage is 98,58%

@jpudysz
Copy link
Owner Author

jpudysz commented Oct 26, 2023

Resolves #49

@jpudysz jpudysz merged commit bd164bb into main Oct 26, 2023
4 checks passed
@jpudysz jpudysz deleted the feature/ssr branch October 26, 2023 09:51
@levibuzolic levibuzolic mentioned this pull request Oct 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jpudysz jpudysz

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jpudysz