Fix potential memory leak with PyBuffer_release

jpy-consortium · Sep 22, 2023 · 56c0cbd · 56c0cbd
1 parent 58d345d
commit 56c0cbd
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/src/main/c/jpy_module.c b/src/main/c/jpy_module.c
@@ -697,12 +697,14 @@ PyObject* JPy_byte_buffer_internal(JNIEnv* jenv, PyObject* self, PyObject* args)
 
     byteBufferRef = (*jenv)->NewDirectByteBuffer(jenv, pyBuffer->buf, pyBuffer->len);
     if (byteBufferRef == NULL) {
+        PyBuffer_Release(pyBuffer);
         PyMem_Free(pyBuffer);
         return PyErr_NoMemory();
     }
 
     newPyObj = JObj_New(jenv, byteBufferRef);
     if (newPyObj == NULL) {
+        PyBuffer_Release(pyBuffer);
         PyMem_Free(pyBuffer);
         return NULL;
     }