Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unencrypted keys #6

Merged
merged 6 commits into from
Feb 4, 2024
Merged

Unencrypted keys #6

merged 6 commits into from
Feb 4, 2024
+60 −13

Conversation

jshawl
Copy link
Owner

@jshawl jshawl commented Feb 4, 2024 •
edited
Loading

Keys generated using:

minisign -GW

should not use the key derivation function while extracting the ed25519 key pair.

Also, Minisign::PrivateKey.new should raise if a password is required, but not supplied.

Lastly, Minisign::PrivateKey.new should raise if the password is incorrect.

@jshawl jshawl marked this pull request as ready for review February 4, 2024 19:33
@jshawl jshawl merged commit 527e7d3 into main Feb 4, 2024
1 check passed
@jshawl jshawl deleted the unencrypted-keys branch February 4, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jshawl