Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsk_rosbag_tools] Fixed pillow version #1799

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Conversation

iory
Copy link
Member

@iory iory commented Apr 4, 2024

Related to #1798

In the course of addressing a build failure related to dependency resolution within our jsk_rosbag_tools package, we encountered an error indicating that pip-compile was unable to properly identify the version of the Pillow package required by imageio==2.34.0 as part of the moviepy==1.0.3 dependency. The error specifically pointed out that the package name or version was not recognized properly, which led to a halt in the dependency resolution process and subsequently the build process.

To resolve this issue, we've explicitly pinned the Pillow version to 8.4.0 in the requirements.in file. This action was taken after thoroughly investigating the underlying problem, which suggested that an explicit declaration could help pip-compile in resolving the correct package version and thus, facilitate a smoother dependency resolution process. Here's the commit that addresses this problem:

@iory iory changed the title [WIP] [jsk_rosbag_tools] Fixed pillow version [jsk_rosbag_tools] Fixed pillow version Apr 4, 2024
Copy link
Member

@k-okada k-okada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI passed!!!

image

@k-okada k-okada merged commit b17d38b into jsk-ros-pkg:master Apr 4, 2024
8 checks passed
@iory iory deleted the fix-#1798 branch April 4, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants