Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pr2eus: partially revert speak function #331

Closed
wants to merge 2 commits into from

Conversation

furushchev
Copy link
Member

This pull request reverts #318 + integrate TTS methods to robot-interface

@k-okada
Copy link
Member

k-okada commented Dec 6, 2017

This is because my comment at #318 (review) which calls (send *ri* :speak) within (sepak-jp) was very bad idea, because all simple node such as warning tools requires *ri*.

@k-okada k-okada self-requested a review December 6, 2017 09:49
@k-okada
Copy link
Member

k-okada commented Dec 6, 2017

/home/travis/ros/ws_jsk_pr2eus/devel/share/pr2eus_tutorials/cmake/pr2eus_tutorialsConfig-version.cmake)
Linked: (/home/travis/ros/ws_jsk_pr2eus/devel/.private/pr2eus_tutorials/share/pr2eus_tutorials/cmake/pr2eus_tutorialsConfig.cmake, /home/travis/ros/ws_jsk_pr2eus/devel/share/pr2eus_tutorials/cmake/pr2eus_tutorialsConfig.cmake)
Linked: (/home/travis/ros/ws_jsk_pr2eus/devel/.private/pr2eus_tutorials/lib/pkgconfig/pr2eus_tutorials.pc, /home/travis/ros/ws_jsk_pr2eus/devel/lib/pkgconfig/pr2eus_tutorials.pc)
Finished <<< pr2eus_tutorials                [ 0.1 seconds ]
[build] Summary: All 3 packages succeeded!
[build] Ignored: None.
[build] Warnings: 2 packages succeeded with warnings.
[build] Abandoned: No packages were abandoned.
[build] Failed: No packages failed.
[build] Runtime: 17 minutes and 38.4 seconds total.
bash: line 1: 12627 Terminated              travis_jigger $! $timeout $cmd
++ return 0
++ catkin_test_results --verbose --all build
Full test results for 'pr2eus/test_results/pr2eus/rosunit-speak_test_node.xml'
-------------------------------------------------
<testsuite tests="4" failures="2" disabled="0" errors="0" time="20" name="AllTests">
  <testcase name="all-test" status="run" time="0" classname="all-test">
  </testcase>
  <testcase name="test-speak-en" status="run" time="10" classname="test-speak-en">
   <failure message="" type="AssertionError">
Test:(speak-en "hello, world" :wait t)
Trace:"^[0mmstart testing [test-speak-en]
jsk_pr2eus/build/pr2eus/test_results/pr2eus/rosunit-speak_test_node.xml
?"
Message:""
   </failure>
  </testcase>
  <testcase name="test-speak-jp" status="run" time="0" classname="test-speak-jp">
  </testcase>
  <testcase name="test-ri-speak-en" status="run" time="10" classname="test-ri-speak-en">
   <failure message="" type="AssertionError">
Test:(send *ri* :speak-en "hello, world" :wait t)
Trace:"^[0mmstart testing [test-ri-speak-en]
xml
?).^[0m
failed ... ( ^[0mmstart testing [test-speak-en]
jsk_pr2eus/build/pr2eus/test_r"
Message:""
   </failure>
  </testcase>
  <testcase name="test-ri-speak-jp" status="run" time="0" classname="test-ri-speak-jp">
  </testcase>
</testsuite>

@furushchev furushchev force-pushed the speak-revert branch 2 times, most recently from 42d56da to d464c00 Compare December 7, 2017 07:20
@furushchev
Copy link
Member Author

Closed via #332

@furushchev furushchev deleted the speak-revert branch December 17, 2017 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants