Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen test condition for test-collision-object-publisher #471

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tkmtnt7000
Copy link
Member

Cc:@708yamaguchi
These days, test-collision-object-publisher failed randomly.
https://github.com/jsk-ros-pkg/jsk_pr2eus/runs/4311911161?check_suite_focus=true

2021-11-24T13:03:52.4925170Z ##[group]catkin_test_results
2021-11-24T13:03:52.4925617Z + error
2021-11-24T13:03:52.4925934Z + travis_time_end 31
2021-11-24T13:03:52.4926253Z + set +x
2021-11-24T13:03:52.4927021Z Full test results for 'pr2eus_moveit/test_results/pr2eus_moveit/rosunit-test_pr2eus_moveit.xml'
2021-11-24T13:03:52.4927820Z -------------------------------------------------
2021-11-24T13:03:52.4928418Z <testsuite tests="9" failures="1" disabled="0" errors="0" time="106" name="AllTests">
2021-11-24T13:03:52.4929259Z   <testcase name="all-test" status="run" time="0" classname="all-test">
2021-11-24T13:03:52.4929759Z   </testcase>
2021-11-24T13:03:52.4931098Z   <testcase name="test-avs-to-angle-vector-make-trajectory" status="run" time="0" classname="test-avs-to-angle-vector-make-trajectory">
2021-11-24T13:03:52.4932229Z   </testcase>
2021-11-24T13:03:52.4933298Z   <testcase name="test-trajectory-filter-vel-acc" status="run" time="0" classname="test-trajectory-filter-vel-acc">
2021-11-24T13:03:52.4934185Z   </testcase>
2021-11-24T13:03:52.4935215Z   <testcase name="test-angle-vector-motion-plan" status="run" time="6" classname="test-angle-vector-motion-plan">
2021-11-24T13:03:52.4936069Z   </testcase>
2021-11-24T13:03:52.4937440Z   <testcase name="test-angle-vector-sequence-motion-plan" status="run" time="23" classname="test-angle-vector-sequence-motion-plan">
2021-11-24T13:03:52.4938541Z   </testcase>
2021-11-24T13:03:52.4939489Z   <testcase name="test-move-end-coords-plan" status="run" time="20" classname="test-move-end-coords-plan">
2021-11-24T13:03:52.4940255Z   </testcase>
2021-11-24T13:03:52.4941311Z   <testcase name="test-moveit-fastest-trajectory" status="run" time="11" classname="test-moveit-fastest-trajectory">
2021-11-24T13:03:52.4942180Z   </testcase>
2021-11-24T13:03:52.4943048Z   <testcase name="test-start-offset-time" status="run" time="14" classname="test-start-offset-time">
2021-11-24T13:03:52.4943738Z   </testcase>
2021-11-24T13:03:52.4944801Z   <testcase name="test-start-offset-time-with-avs" status="run" time="16" classname="test-start-offset-time-with-avs">
2021-11-24T13:03:52.4945690Z   </testcase>
2021-11-24T13:03:52.4946788Z   <testcase name="test-collision-object-publisher" status="run" time="16" classname="test-collision-object-publisher">
2021-11-24T13:03:52.4947949Z    <failure message="Collision occurred between pr2 and cubes" type="AssertionError">
2021-11-24T13:03:52.4948777Z Test:(not collision-check-result)
2021-11-24T13:03:52.4949669Z Trace:"^[0mmstart testing [test-collision-object-publisher]
2021-11-24T13:03:52.4950594Z t&amp;gt; :joint-angle(0.0) violate min-angle(11.5)
2021-11-24T13:03:52.4950998Z .5)
2021-11-24T13:03:52.4951337Z est_pr2eus_moveit.xml
2021-11-24T13:03:52.4951819Z ¨U"
2021-11-24T13:03:52.4952265Z Message:"Collision occurred between pr2 and cubes"
2021-11-24T13:03:52.4952710Z    </failure>
2021-11-24T13:03:52.4953021Z   </testcase>
2021-11-24T13:03:52.4953341Z </testsuite>

We loosen the test condition.
This ros::rate value is adjusted so that the test passes when moveit is used, but fails when moveit is not used.

Copy link
Member

@708yamaguchi 708yamaguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before:
pqp collision check is executed at 10hz while pr2 is moving in gazebo.

After:
pqp collision check is executed at 1hz while pr2 is moving in gazebo.

I hope test failure rate will decrease with this PR.

@tkmtnt7000
Copy link
Member Author

kick test by closing/opening this pull request

@tkmtnt7000 tkmtnt7000 reopened this Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants