Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Dark Crystal #332

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

evilwraith
Copy link
Contributor

@evilwraith evilwraith commented Oct 31, 2024

Adds FlexDMD to The Dark Crystal table.

Original table:

https://www.vpforums.org/index.php?app=downloads&showfile=15008

Adds FlexDMD to The Dark Crystal table.
@francisdb
Copy link
Contributor

Why is this needed? To get DMD output on an external dmd?

We tend to label these DMD fixes as .vbs.dmd just to make clear they do more than fixing script issues.
I also suggest reporting this patch to the table writer as it could be useful for more than only standalone?

@francisdb
Copy link
Contributor

francisdb commented Nov 1, 2024

The scanline effect is a bit messed up, probably because of a different height?

image

@francisdb
Copy link
Contributor

With Const FlexDMDHighQuality = False there is a script error:

2024-11-01 14:59:45.494 ERROR [1051192] [CodeViewer::OnScriptError@1213] Script Error at line 1728 : VBSE_OLE_NO_PROP_OR_METHOD
2024-11-01 14:59:45.496 ERROR [1051192] [CodeViewer::AppendLastErrorTextW@4032] Runtime error: Line: 1728, Character: 16, VBSE_OLE_NO_PROP_OR_METHOD

@francisdb
Copy link
Contributor

The scanline effect is a bit messed up, probably because of a different height?

image

Nothing much can be done about this as the source images have the pixel effect

image

@francisdb
Copy link
Contributor

francisdb commented Nov 1, 2024

Mind adding the table url to the PR description?

@evilwraith
Copy link
Contributor Author

Why is this needed? To get DMD output on an external dmd?

We tend to label these DMD fixes as .vbs.dmd just to make clear they do more than fixing script issues. I also suggest reporting this patch to the table writer as it could be useful for more than only standalone?

This has actually been requested quite a bit on different threads that I've seen. I'm not sure the author would be interested in updating. I'll put in the requested changes.

Fixed Line 1728 error

Changed filename to .vbs.dmd

Original table is here:

https://www.vpforums.org/index.php?app=downloads&showfile=15008
@francisdb
Copy link
Contributor

Can you add the link to the table in the pr description, then this is good to go @jsm174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants