New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Favor the Disposal Pattern #104

Open

jsmecham wants to merge 4 commits into master from dispose-all-the-things

Owner

jsmecham commented Jan 23, 2019

Renames destroy() to dispose() internally and manage everything we can with CompositeDisposable.

jsmecham added 3 commits

January 22, 2019 21:19


          Updated Xterm.js to 3.10.1 and added package lock.

63d3d82


          Updated Etch to 0.14.0.

370318b


          Removed outdated note about requiring Atom 1.17 or later.

bb86910

jsmecham force-pushed the dispose-all-the-things branch from bafa26f to 7b4fa7e Compare

January 23, 2019 03:17


          Switched to the disposable pattern wherever possible.

a4c0a26

jsmecham force-pushed the dispose-all-the-things branch from 7b4fa7e to a4c0a26 Compare

January 23, 2019 03:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet